Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust active element visibility in the sidebar #4155

Merged
merged 1 commit into from
May 25, 2023
Merged

adjust active element visibility in the sidebar #4155

merged 1 commit into from
May 25, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 25, 2023 •
edited by JuliaKirschenheuter
Loading

fixes nextcloud/server#36947

Before After
image image

@szaimen
fix active vue sidebar
bc9a5e3 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels May 25, 2023
@szaimen szaimen changed the title fix active vue sidebar adjust active element visibility in the sidebar May 25, 2023
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 25, 2023
@szaimen szaimen marked this pull request as ready for review May 25, 2023 11:17
jancborchardt
jancborchardt approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

JuliaKirschenheuter
JuliaKirschenheuter reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stolen my ticket 😅😅
fixes nextcloud/server#36947, no?
have you tested Talk and Mail too?
Light / Dark mode?

@szaimen
Copy link
Contributor Author

szaimen commented May 25, 2023

have you tested Talk and Mail too?

talk uses a different component. Will look into adjusting that as well...

@szaimen szaimen merged commit 04ba027 into master May 25, 2023
@szaimen szaimen deleted the enh/noid/fix-active-vue-sidebar branch May 25, 2023 13:17
@skjnldsv skjnldsv mentioned this pull request Sep 27, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@szaimen szaimen

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities
Projects
None yet
Milestone
No milestone
3 participants
@szaimen @jancborchardt @JuliaKirschenheuter